Skip to content

docs: add example of testing React Navigation #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 24, 2020
Merged

docs: add example of testing React Navigation #277

merged 14 commits into from
Apr 24, 2020

Conversation

cross19xx
Copy link
Contributor

@cross19xx cross19xx commented Apr 17, 2020

Summary

This PR includes

  • setup an example of testing React Navigation navigator with default screen
  • integration with the website

Part of #280

@cross19xx cross19xx requested a review from thymikee April 17, 2020 00:58
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start! We can't merge it without an actual example just yet

@thymikee thymikee changed the title feat: Embed codesandbox projects into website docs: add example of testing React Navigation Apr 24, 2020
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good base 👍. What users usually need is to render a specific screen, so we should add that as a followup :)

@thymikee
Copy link
Member

We'll also need to set up running tests for examples, let's do it in a followup

@thymikee thymikee merged commit 95b4889 into callstack:master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants