feat: add "cleanup" function #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Dec 6, 2019
Esemesek
approved these changes
Dec 9, 2019
|
Can this be published to npm now? |
|
@aleclarson yup, just released v1.12. Thanks for this contribution! |
|
Should we update the readme to say that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#234 (comment)
Every
rendercall stores itsunmountfunction in a globalSetcalledcleanup.queue. This is how RTL does it (except it doesn't expose the queue). I exposed the queue oncleanupbecause it was easiest. You can adjust that in a follow-up commit if you want.The
cleanupfunction is never called automatically in this PR.Test plan
f08f132