Skip to content

fix: correct typings for a11y queries #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2019
Merged

fix: correct typings for a11y queries #205

merged 3 commits into from
Jul 17, 2019

Conversation

Esemesek
Copy link
Collaborator

Summary

Fix for getAllByA11y* types.

Types were failing for following use case:

fireEvent.press(getAllByA11yLabel('label')[0]);

@Esemesek Esemesek requested a review from thymikee July 17, 2019 09:47
thymikee
thymikee approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@thymikee thymikee changed the title fix: Fix flow type for a11y queries fix: correct typings for a11y queries Jul 17, 2019
@thymikee thymikee merged commit d216b10 into master Jul 17, 2019
@thymikee thymikee deleted the fix-typing branch July 17, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Esemesek @thymikee