-
Notifications
You must be signed in to change notification settings - Fork 274
fix: disable container deprecation warning (main) #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1362 +/- ##
==========================================
- Coverage 96.13% 96.12% -0.01%
==========================================
Files 49 49
Lines 3364 3359 -5
Branches 503 503
==========================================
- Hits 3234 3229 -5
Misses 130 130
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MattAgn
approved these changes
Mar 8, 2023
pierrezimmermannbam
approved these changes
Mar 8, 2023
AugustinLF
approved these changes
Mar 8, 2023
hyochan
referenced
this pull request
in hyochan/dooboo-ui
Mar 19, 2023
….4 (#285) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@testing-library/react-native](https://callstack.github.io/react-native-testing-library) ([source](https://togithub.com/callstack/react-native-testing-library)) | [`11.5.2` -> `11.5.4`](https://renovatebot.com/diffs/npm/@testing-library%2freact-native/11.5.2/11.5.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>callstack/react-native-testing-library</summary> ### [`v11.5.4`](https://togithub.com/callstack/react-native-testing-library/releases/tag/v11.5.4) [Compare Source](https://togithub.com/callstack/react-native-testing-library/compare/v11.5.3...v11.5.4) #### What's Changed ##### Bug fixes - fix: disable container deprecation warning triggered by rest destructuring operator on `render` result by [@​mdjastrzebski](https://togithub.com/mdjastrzebski) in [https://github.com/callstack/react-native-testing-library/pull/1362](https://togithub.com/callstack/react-native-testing-library/pull/1362) **Full Changelog**: callstack/react-native-testing-library@v11.5.3...v11.5.4 ### [`v11.5.3`](https://togithub.com/callstack/react-native-testing-library/releases/tag/v11.5.3) [Compare Source](https://togithub.com/callstack/react-native-testing-library/compare/v11.5.2...v11.5.3) #### What's Changed ##### Bugfixes - fix type issues for `AccessibilityState` when using `skipLibCheck: false` resulting from migration from `@types/react-native` to internal `react-native` types ([#​1355](https://togithub.com/callstack/react-native-testing-library/issues/1355)) by [@​mdjastrzebski](https://togithub.com/mdjastrzebski) in [https://github.com/callstack/react-native-testing-library/pull/1361](https://togithub.com/callstack/react-native-testing-library/pull/1361) **Full Changelog**: callstack/react-native-testing-library@v11.5.2...v11.5.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/dooboolab/dooboo-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMTAuMiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1350 on
main
Above code, frequently used for building custom render functions, triggers
container
console warning, as rest operator causescontainer
property to be read and hence the error logged. To avoid this unnecessary and not actionable noise for the users I disabled the console warning.Test plan
All checks should pass.