Skip to content

fix: duplicate AccessibilityState type (#1355) #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

mdjastrzebski
Copy link
Member

Summary

Cherry pick of #1355 to main.

Test plan

All checks should pass.

@mdjastrzebski mdjastrzebski marked this pull request as ready for review March 6, 2023 19:22
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (0bd11a4) 96.09% compared to head (384ffe7) 96.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1361      +/-   ##
==========================================
+ Coverage   96.09%   96.13%   +0.03%     
==========================================
  Files          49       49              
  Lines        3333     3364      +31     
  Branches      503      503              
==========================================
+ Hits         3203     3234      +31     
  Misses        130      130              
Impacted Files Coverage Δ
src/helpers/matchers/accessibilityState.ts 100.00% <100.00%> (ø)
src/queries/a11yState.ts 100.00% <100.00%> (ø)
src/queries/role.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mdjastrzebski mdjastrzebski merged commit eb2e087 into main Mar 7, 2023
@mdjastrzebski mdjastrzebski deleted the fix/accessibilty-state-typing branch March 7, 2023 07:00
hyochan referenced this pull request in hyochan/dooboo-ui Mar 19, 2023
….4 (#285)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@testing-library/react-native](https://callstack.github.io/react-native-testing-library)
([source](https://togithub.com/callstack/react-native-testing-library))
| [`11.5.2` ->
`11.5.4`](https://renovatebot.com/diffs/npm/@testing-library%2freact-native/11.5.2/11.5.4)
|
[![age](https://badges.renovateapi.com/packages/npm/@testing-library%2freact-native/11.5.4/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@testing-library%2freact-native/11.5.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@testing-library%2freact-native/11.5.4/compatibility-slim/11.5.2)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@testing-library%2freact-native/11.5.4/confidence-slim/11.5.2)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>callstack/react-native-testing-library</summary>

###
[`v11.5.4`](https://togithub.com/callstack/react-native-testing-library/releases/tag/v11.5.4)

[Compare
Source](https://togithub.com/callstack/react-native-testing-library/compare/v11.5.3...v11.5.4)

#### What's Changed

##### Bug fixes

- fix: disable container deprecation warning triggered by rest
destructuring operator on `render` result by
[@&#8203;mdjastrzebski](https://togithub.com/mdjastrzebski) in
[https://github.com/callstack/react-native-testing-library/pull/1362](https://togithub.com/callstack/react-native-testing-library/pull/1362)

**Full Changelog**:
callstack/react-native-testing-library@v11.5.3...v11.5.4

###
[`v11.5.3`](https://togithub.com/callstack/react-native-testing-library/releases/tag/v11.5.3)

[Compare
Source](https://togithub.com/callstack/react-native-testing-library/compare/v11.5.2...v11.5.3)

#### What's Changed

##### Bugfixes

- fix type issues for `AccessibilityState` when using `skipLibCheck:
false` resulting from migration from `@types/react-native` to internal
`react-native` types
([#&#8203;1355](https://togithub.com/callstack/react-native-testing-library/issues/1355))
by [@&#8203;mdjastrzebski](https://togithub.com/mdjastrzebski) in
[https://github.com/callstack/react-native-testing-library/pull/1361](https://togithub.com/callstack/react-native-testing-library/pull/1361)

**Full Changelog**:
callstack/react-native-testing-library@v11.5.2...v11.5.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/dooboolab/dooboo-ui).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMTAuMiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant