Skip to content

docs: Remove misleading recommendation to use shallow in snapshot tests #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2019
Merged

docs: Remove misleading recommendation to use shallow in snapshot tests #128

merged 1 commit into from
Mar 7, 2019

Conversation

Ingibjorg
Copy link
Contributor

Summary

I removed misleading recommendation to render components with shallow in snapshot tests as a result of the conversation in Issue #127.

Test plan

Review text in API.md

thymikee
thymikee approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@thymikee thymikee merged commit 09f9b9f into callstack:master Mar 7, 2019
@Ingibjorg Ingibjorg deleted the docs/fix-misleading-shallow-doc branch March 7, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ingibjorg @thymikee