Add queryOptions to labelText and hintText

[ShaswatPrabhat]

Changes for PR

[AugustinLF]

Could you please add tests? See https://github.com/callstack/react-native-testing-library/blob/main/src/queries/__tests__/text.test.tsx#L293 for how we tested TextMatch options

[ShaswatPrabhat]

Have added the tests @AugustinLF

Some label text tests are still failing though. Will appreciate some help there as well, thanks.

[mdjastrzebski]

@ShaswatPrabhat looks good, pls also update documentation in Queries.md

[mdjastrzebski]

@ShaswatPrabhat looks like there are some CircleCI issues. Are the tests are passing locally on your machine?

[ShaswatPrabhat]

Some tests for Label are failing even on my local @mdjastrzebski, hence needed help. Wondering what I did wrong for the tests to start failing.

Seems after my change it is not picking labels from all 3 components:

Please find screenshot of the failure below:

[ShaswatPrabhat]

The earlier matchStringProp method:

 return prop.match(matcher) != null;

But the matches.ts method:

 return matcher.test(normalizedText);

And hence the delta.

[mdjastrzebski]

I've fixed the failing tests. There was a rather obscure bug connected with the fact that RegExp.test() is stateful with global queries, and you need to reset the regex state in order to work correctly 🤦🏻‍♂️

Happy that you stumbled upon it, because it could impact our other queries as well 🎉

[ShaswatPrabhat]

@mdjastrzebski Thank you. Is it good to merge the changes ?

[AugustinLF]

You also need to update the flow types :)

Apart from that and my other comment, looks good to me.

[ShaswatPrabhat]

Have pushed some changes for both observations @AugustinLF . Please have a look whenever possible. Thanks.

[mdjastrzebski]

Since findByLabelText and findByPlaceholderText now use 2nd parameter for query options, pushing waitForOptions to 3rd parameter, I had to bring back deprecated wait for parsing from the past to avoid triggering breaking change.

[codecov]

Codecov Report

Base: 93.90% // Head: 94.04% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (363da3c) compared to base (8e5c9f9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1193      +/-   ##
==========================================
+ Coverage   93.90%   94.04%   +0.14%     
==========================================
  Files          41       41              
  Lines        2706     2773      +67     
  Branches      410      418       +8     
==========================================
+ Hits         2541     2608      +67     
  Misses        165      165              

Impacted Files	Coverage Δ
src/matches.ts	100.00% <100.00%> (ø)
src/queries/hintText.ts	100.00% <100.00%> (ø)
src/queries/labelText.ts	100.00% <100.00%> (ø)
src/queries/makeQueries.ts	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mdjastrzebski]

Looks good for me!

@ShaswatPrabhat I've added hacktoberfest-accepted tag to mark it eligible for hacktoberfest despite not being merged yet.

@AugustinLF could you take a look if everything is fine for you?

[mdjastrzebski]

Seems like we still need to update docs

[mdjastrzebski]

I've updated docs