feature: basic example app #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Jul 27, 2022
thymikee
reviewed
Jul 27, 2022
| // for the action to complete. | ||
| // Hint: subsequent queries do not need to use `findBy`, because they are used after the async action | ||
| // already finished | ||
| expect(await screen.findByText('Welcome admin!')).toBeTruthy(); |
There was a problem hiding this comment.
There's no need to expect everything, right? This reads better as a scenario to me:
Suggested change
| expect(await screen.findByText('Welcome admin!')).toBeTruthy(); | |
| await screen.findByText('Welcome admin!')); |
There was a problem hiding this comment.
Yeah thats a good question, I'used that in a similar pattern as we suggest using expect(getByText()).toBeTruthy() to clarify the intent, despite the fact that simple getByText would do the same.
thymikee
reviewed
Jul 27, 2022
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
|
I've migrated the example to use Expo managed. |
thymikee
reviewed
Jul 28, 2022
thymikee
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Basic modern example for using RNTL. The app is generated from RN CLI template so there is some iOS/Android boilerplate but the benefit here is that we work on a real RN app and not an empty shell of it.
I also plan to use it as a base for refresh of other example apps.
Test plan
All checks and tests pass.