Skip to content

chore: drop 0.71 support from podspec #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2025
Merged

Conversation

okwasniewski
Copy link
Member

Summary

Since React Native 0.75 is dropping support soon, I decided to remove this check for 0.71 this makes the podspec a lot cleaner.

Test plan

CI Green

@okwasniewski okwasniewski changed the title chore: drop 0.71 support chore: drop 0.71 support from podspec Feb 26, 2025
@okwasniewski okwasniewski requested review from atlj and satya164 and removed request for atlj February 26, 2025 14:46
@satya164
Copy link
Member

Does it affect old architecture? If yes I think we should drop it together with dropping support for old architecture, once new architecture is a bit more stabilized. Normally Bob doesn't drop compatibility unless there's a breaking change that makes it necessary.

Though seems all of that new architecture specific code inside the if condition isn't needed either way so can be dropped.

@okwasniewski
Copy link
Member Author

@satya164 No it doesn't install_modules_dependencies is used for both old and new arch

@satya164
Copy link
Member

@satya164 No it doesn't install_modules_dependencies is used for both old and new arch

But isn't that method only available from 0.71? Then the current code does affect both old and new architecture and the change will drop support for old architecture on 0.71 and earlier.

…%- project.name %}.podspec

Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
@satya164 satya164 merged commit d855e52 into main Mar 15, 2025
21 checks passed
@satya164 satya164 deleted the @okwasniewski/drop-0-71-support branch March 15, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants