refactor: drop backward compatible templates #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
force-pushed
the
@satya164/backward-compatible
branch
4 times, most recently
from
ba4a91c to
7dba6b5
Compare
As of React Native 0.76, the new architecture is now default. So this moves the templates with new architecture up. New libraries should start with new arch template. For legacy usage, we still have the legacy template for now. Old architecture libraries still work in new architecture via compat layer. So the backward compatible templates are unnecessary. They are also difficult to maintain and are currently broken, so I'm removing them.
satya164
force-pushed
the
@satya164/backward-compatible
branch
from
7dba6b5 to
cd6fd65
Compare
|
hi @satya164 just want to confirm, library generated using |
|
@maitrungduc1410 the latest templates only support the new architecture. you will need to use an older version to generate project for old architecture (0.49.8 for legacy templates and 0.44.3 for backward compatible templates). react native docs also say you can support old architecture on Android by using https://reactnative.dev/docs/the-new-architecture/codegen-cli#enabling-includesgeneratedcode |
|
Got it, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of React Native 0.76, the new architecture is now default. So this moves the templates with new architecture up. New libraries should start with new arch template.
For legacy usage, we still have the legacy template for now. Old architecture libraries still work in new architecture via compat layer. So the backward compatible templates are unnecessary. They are also difficult to maintain and are currently broken, so I'm removing them.