Skip to content

Fix Java Client Build #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2021

Conversation

demirkayaender
Copy link
Contributor

@demirkayaender demirkayaender commented Jul 13, 2021

Java client started using java11:alpine in April. Since we were using the branch instead of a specific commit, we have been getting updates for jdk. One of those updates 15 days ago ended up breaking the build and all the subsequent builds failed: https://buildkite.com/uberopensource/cadence-java-client/builds?branch=master&page=2

This change freezes the jdk version to a specific hash so we won't have similar breakages in the future.

I also switched to using paths with no variables like $projectDir; this was because usage of it initially mislead us to think the issue was with the projectDir variable. I'm fine with either way but this way we wouldn't really suspect if there's any issue with the variables.

@demirkayaender demirkayaender force-pushed the fix_build branch 17 times, most recently from db5ec49 to df6f720 Compare July 14, 2021 04:12
@coveralls
Copy link

coveralls commented Jul 14, 2021

Pull Request Test Coverage Report for Build 813

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 71.398%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/sync/WorkflowThreadContext.java 1 82.46%
Totals Coverage Status
Change from base Build 764: -0.007%
Covered Lines: 10664
Relevant Lines: 14936

💛 - Coveralls

@demirkayaender demirkayaender changed the title Try fixing the Buildkite issues Fix Java Client Build Jul 14, 2021
@demirkayaender demirkayaender requested a review from a team July 14, 2021 04:43
Copy link
Contributor

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I watched how you fixed it it seemed very painful. Is there any idea to prevent or improve in the future? If we have some nightly run integ test would it be easier to discover and fix earlier?

@demirkayaender
Copy link
Contributor Author

Is there any idea to prevent or improve in the future? If we have some nightly run integ test would it be easier to discover and fix earlier?

We have continuous builds, I'm thinking we should create alerts on it so we can get notified when it breaks. Thanks everyone for the quick review! I will address the comments

@demirkayaender demirkayaender merged commit 5008365 into cadence-workflow:master Jul 14, 2021
@demirkayaender demirkayaender deleted the fix_build branch July 14, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants