-
Notifications
You must be signed in to change notification settings - Fork 113
Fix Java Client Build #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Java Client Build #625
Conversation
db5ec49
to
df6f720
Compare
df6f720
to
3ed171e
Compare
Pull Request Test Coverage Report for Build 813
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. I watched how you fixed it it seemed very painful. Is there any idea to prevent or improve in the future? If we have some nightly run integ test would it be easier to discover and fix earlier?
We have continuous builds, I'm thinking we should create alerts on it so we can get notified when it breaks. Thanks everyone for the quick review! I will address the comments |
b8491d6
to
49b08f8
Compare
Java client started using java11:alpine in April. Since we were using the branch instead of a specific commit, we have been getting updates for jdk. One of those updates 15 days ago ended up breaking the build and all the subsequent builds failed: https://buildkite.com/uberopensource/cadence-java-client/builds?branch=master&page=2
This change freezes the jdk version to a specific hash so we won't have similar breakages in the future.
I also switched to using paths with no variables like $projectDir; this was because usage of it initially mislead us to think the issue was with the projectDir variable. I'm fine with either way but this way we wouldn't really suspect if there's any issue with the variables.