Skip to content

Make client to be Java 11 compatible #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Apr 21, 2021

what?

Make client to be Java 11 compatible. Use Java 11 to compile Java 8 code and release Java 8 bytecode to prepare for future migartion.

@coveralls
Copy link

coveralls commented Apr 22, 2021

Pull Request Test Coverage Report for Build 671

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.003%) to 71.838%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/sync/DeterministicRunnerImpl.java 1 84.1%
src/main/java/com/uber/cadence/internal/worker/BlockCallerPolicy.java 1 62.5%
Totals Coverage Status
Change from base Build 661: -0.003%
Covered Lines: 10678
Relevant Lines: 14864

💛 - Coveralls

@Shaddoll Shaddoll force-pushed the jdk-11 branch 2 times, most recently from 77e9915 to ba8c98f Compare April 27, 2021 23:57
@Shaddoll Shaddoll changed the title Java 11 support Make client to be Java 11 compatible Apr 28, 2021
@Shaddoll Shaddoll merged commit 229dd2c into cadence-workflow:master Apr 28, 2021
demirkayaender added a commit to demirkayaender/cadence-java-client that referenced this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants