Skip to content

Support workflow completed error in java client #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

demirkayaender
Copy link
Contributor

What changed?
Similar changes to here: cadence-workflow/cadence-go-client#1081 for the java client.

Why?

How did you test it?

Potential risks

@demirkayaender demirkayaender requested a review from a team April 16, 2021 23:14
Copy link
Contributor

@yux0 yux0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could we add some tests to make sure this new errors are not retry?
As this is a breaking change, may be update the version in internal/Version.java as well

@meiliang86 meiliang86 requested a review from a team April 18, 2021 17:01
@demirkayaender demirkayaender force-pushed the already_completed_error_java branch from c6ec4fa to 5044f1a Compare April 19, 2021 18:10
@demirkayaender
Copy link
Contributor Author

What changed?
Similar changes to here: cadence-workflow/cadence-go-client#1081 for the java client.

Why?

How did you test it?

Potential risks

@demirkayaender demirkayaender merged commit 8de07b9 into cadence-workflow:master Apr 19, 2021
@demirkayaender demirkayaender deleted the already_completed_error_java branch April 19, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants