Skip to content

Bunq.Sdk support for .netstandard15 #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Bunq.Sdk support for .netstandard15 #86

wants to merge 1 commit into from

Conversation

michielpost
Copy link
Contributor

Related issue: #26

By creating a .netstandard library, this library can be used on a lot more platforms.

@OGKevin
Copy link
Contributor

OGKevin commented Apr 1, 2018

Hey @michielpost

Thanks for your contribution.

Do you mind following the guidelines located here: https://raw.githubusercontent.com/bunq/sdk_csharp/92f406f8cf8701e214d16c5766cbf1092f25e729/.github/PULL_REQUEST_TEMPLATE.md

In your case, the commit msg is not correct.

@michielpost
Copy link
Contributor Author

I made this for a colleague who wanted to use the Bunq SDK on another platform and used my own commit guidelines :)
I think it can benefit more developers. It's probably easier for you to have a look at the commit, do the changes yourself in another commit and close this PR.

@OGKevin
Copy link
Contributor

OGKevin commented Apr 3, 2018

@michielpost closing in favour of #88. You will still be listed as contributor however 😉.

Thanks for your contribution.

@OGKevin OGKevin closed this Apr 3, 2018
@michielpost
Copy link
Contributor Author

Fancy git stuff, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants