Skip to content

feat(defaultimport): default import mixed parsing #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 2, 2017

Conversation

buehler
Copy link
Owner

@buehler buehler commented Oct 2, 2017

Feature to parse the default import syntax of the newer typescript:

const parsed = await parser.parseSource(`import Foo, { Foobar } from 'myLib';`);
const parsed = await parser.parseSource(`import Foo from 'myLib';`);
const parsed = await parser.parseSource(`import { Foo } from 'myLib';`);
const parsed = await parser.parseSource(`import { Foo, default as Bar } from 'myLib';`);

Does remove the default import definition from the generator.

BREAKING CHANGE: Remove the default import definition from the declarations.
The default imports are now generated by namedImport instead of it's
own definition. The namedImport has now a defaultAlias property that
generates the default import if needed.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.436% when pulling 0c8894f on feat/default-import-mixed-parsing into fac4287 on develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.436% when pulling 0c8894f on feat/default-import-mixed-parsing into fac4287 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.436% when pulling 0c8894f on feat/default-import-mixed-parsing into fac4287 on develop.

@buehler buehler merged commit 40c6b69 into develop Oct 2, 2017
@buehler buehler deleted the feat/default-import-mixed-parsing branch October 2, 2017 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants