Skip to content

Handle saving files without extensions #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

btargac
Copy link
Owner

@btargac btargac commented Mar 28, 2021

  • will add the extension retrieved from mime-type / Content-type header from the http response
  • will avoid over writing the existing files if there are multiple urls with the exact same path
  • get rid of optional chaining plugin of babel, since its included in the core modules of babel
  • update browserlist file to reduce the number of polyfills added to the bundle
  • and as always update some dependencies

@btargac btargac force-pushed the feature/handle-extension-free-urls branch from c937981 to bdea888 Compare March 28, 2021 13:31
@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #54 (bdea888) into master (d15dd2e) will increase coverage by 5.47%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   13.04%   18.51%   +5.47%     
==========================================
  Files           1        2       +1     
  Lines          46       54       +8     
  Branches        5        6       +1     
==========================================
+ Hits            6       10       +4     
- Misses         35       39       +4     
  Partials        5        5              
Impacted Files Coverage Δ
src/utils/processItems.js 13.72% <10.00%> (+0.68%) ⬆️
src/utils/generateFileName.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15dd2e...bdea888. Read the comment docs.

@btargac btargac merged commit dfcb70d into master Mar 29, 2021
@btargac btargac deleted the feature/handle-extension-free-urls branch March 29, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant