Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

[FIX] [generic-type-naming] Add rule #231

Closed
wants to merge 1 commit into from
Closed

[FIX] [generic-type-naming] Add rule #231

wants to merge 1 commit into from

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Dec 16, 2018 •
edited
Loading

This PR changes logic behind generic-type-naming and makes it more generic

  • TSAbstracClassDeclaration and ***ClassExpression is going to be processed

Do not merge

@armano2 armano2 force-pushed the generic-type-naming branch from 435db18 to 8bf96c5 Compare December 16, 2018 02:38
bradzacher
bradzacher suggested changes Dec 16, 2018
View reviewed changes
Copy link
Owner

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll mark as request changes until the parser update is released so that we don't accidentally merge it.

@bradzacher bradzacher added the WIP PRs that are work in progress label Dec 17, 2018
@armano2 armano2 force-pushed the generic-type-naming branch from fdfe5e9 to 51fae62 Compare December 27, 2018 21:38
@bradzacher bradzacher changed the title [FIX] generic-type-naming for abstract classes [FIX] [generic-type-naming] Add rule Jan 8, 2019
@armano2 armano2 closed this Jan 18, 2019
@armano2 armano2 deleted the generic-type-naming branch April 15, 2023 23:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher requested changes

Assignees
No one assigned
Labels
needs type info WIP PRs that are work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armano2 @bradzacher @j-f1