Websockets not working with pusher-php-server 7.2

[szabrzyski]

Hello, after pusher-php-server has been updated to version 7.2 websockets stopped working. I'm using Laravel Echo and the initial connection to private channel is successful, but then I'm not getting any events broadcasted on that channel. With pusher-php-server 7.0.2 everything works fine. Is the new version incompatible with Laravel Websockets and should I wait for an update?

[dunakov]

I also lowered version for stable work laravel-websockets)

[mankms]

Workaround

composer require pusher/pusher-php-server:7.0.2

[Nielson]

Holy shit. Thanks @szabrzyski ! I've been struggling with this for 1½ weeks now and couldn't figure out why my client side didn't catch the event.

[LipeApp]

Когда планируется обновления? На 7.2 много чего который хотели бы пробовать.

[luceos]

I have traced the issue to this: https://github.com/pusher/pusher-http-php/pull/329/files#r993378977

TLDR, the new payload for when dispatching to one channel is channel not channels.

[madpilot78]

Also experiencing this issue.

A bug report has been filed also at pusher/pusher-http-php#351

@luceos Strange, actually beyondcode/laravel-websockets does accept both channel and channels:

laravel-websockets/src/API/TriggerEvent.php

Line 21 in 1f25913

if ($request->has('channel')) {

Have you actually tested a patch that solves the issue?

[luceos]

I don't know then @madpilot78; truth be told I have a fork because I needed a custom implementation for a @flarum extension. And in this fork it now works. Diffing the last version with the new one, and testing things locally, only the channel change has been the most apparent one.

The code you mentioned, which correctly adds the ability to read channel if it is set, was only merged into master 8 days ago, whereas the last release is from March for 1.x. I assume that's the culprit, these changes haven't been released yet and so any published version of this package will still only allow channels in the payload.

[madpilot78]

I don't know then @madpilot78; truth be told I have a fork because I needed a custom implementation for a @flarum extension. And in this fork it now works. Diffing the last version with the new one, and testing things locally, only the channel change has been the most apparent one.

No you're probably right, I'm going to test again.

The code you mentioned, which correctly adds the ability to read channel if it is set, was only merged into master 8 days ago, whereas the last release is from March for 1.x. I assume that's the culprit, these changes haven't been released yet and so any published version of this package will still only allow channels in the payload.

Oh, sorry, my bad I did not check when it was added. Then I'll test using code with that addition, maybe forcing using the repo head.

[madpilot78]

I've tested and filed pull request #1046 against branch 1.x that should fix the issue.

Thanks to @luceos for pointing me in the right direction.

[vnestoruk]

Two days that will never come back 😓 Thanks guys, at least you saved my nerves 🫡

[tomvo]

thanks @madpilot78 for fixing this, we're currently struggling with this issue on production. Any timeline on when this will be merged and tagged?

[octhavio]

composer require pusher/pusher-php-server:7.0.2

Thank you so much! I've been stuck on this issue for days. You are my hero. I consider you from now on one of my closest friends. We're practically family now.

[Wernke96]

@mpociot since we got this package merge in is there any chance we could make a release for this?