-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Move TPA to PID profile #11779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TPA to PID profile #11779
Conversation
This comment has been minimized.
This comment has been minimized.
f069feb
to
d701358
Compare
This comment has been minimized.
This comment has been minimized.
d701358
to
997a11f
Compare
This comment has been minimized.
This comment has been minimized.
997a11f
to
44d433d
Compare
This comment has been minimized.
This comment has been minimized.
44d433d
to
9fec5a0
Compare
This comment has been minimized.
This comment has been minimized.
AUTOMERGE: (FAIL)
|
Do we need to move mode? Not many people change it and you wouldn’t be likely to change the mode profile to profile |
9fec5a0
to
955a053
Compare
This comment has been minimized.
This comment has been minimized.
955a053
to
da48910
Compare
This comment has been minimized.
This comment has been minimized.
da48910
to
2ab84a4
Compare
This comment has been minimized.
This comment has been minimized.
2ab84a4
to
f754719
Compare
Do you want to test this code? Here you have an automated build: |
Yes, why would you want to keep TPA settings in with rates? It doesn't make sense in the first place, and it makes even less sense to have TPA settings straddling both the pid profile and the rate profile. |
Profile settings can't be changed while flying, but rate profiles can. We should consider re-naming 'rate profiles' to something else that reflects their ability to be adjusted while in-flight. In this particular case, what is the advantage of making TPA settings adjustable while in-flight? |
@ctzsnooze This PR moves TPA rate and breakpoint settings from Rate profile to PID profile. Renaming Rate profiles to Flight Profiles should be done in a separate PR. |
Thanks! |
Move
tpa_rate
,tpa_breakpoint
from Rate Profile to PID profile.Move
tpa_mode
from Rate Profile to PID config.