Skip to content

Move TPA to PID profile #11779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Aug 6, 2022

Move tpa_rate, tpa_breakpoint from Rate Profile to PID profile.
Move tpa_mode from Rate Profile to PID config.

@haslinghuis haslinghuis added this to the 4.4 milestone Aug 6, 2022
@haslinghuis haslinghuis self-assigned this Aug 6, 2022
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Aug 7, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@sugaarK
Copy link
Member

sugaarK commented Aug 7, 2022

Do we need to move mode? Not many people change it and you wouldn’t be likely to change the mode profile to profile

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@haslinghuis haslinghuis marked this pull request as draft August 7, 2022 20:31
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@Quick-Flash
Copy link
Contributor

Do we need to move mode? Not many people change it and you wouldn’t be likely to change the mode profile to profile

Yes, why would you want to keep TPA settings in with rates? It doesn't make sense in the first place, and it makes even less sense to have TPA settings straddling both the pid profile and the rate profile.

@ctzsnooze
Copy link
Member

Profile settings can't be changed while flying, but rate profiles can.

We should consider re-naming 'rate profiles' to something else that reflects their ability to be adjusted while in-flight.

In this particular case, what is the advantage of making TPA settings adjustable while in-flight?

@haslinghuis
Copy link
Member Author

@ctzsnooze This PR moves TPA rate and breakpoint settings from Rate profile to PID profile.

Renaming Rate profiles to Flight Profiles should be done in a separate PR.

@haslinghuis haslinghuis merged commit cbbc80e into betaflight:master Oct 13, 2022
@haslinghuis haslinghuis deleted the update-pidprofile branch October 13, 2022 19:09
@ctzsnooze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants