Register Attributes Without Changes to ZEND APIs #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Jun 4, 2020
nikic
reviewed
Jun 4, 2020
|
@nikic I followed your suggestions and adjusted the code accordingly. I dropped the str-functions from the header, having the returned pointers is enough for attribute registration. |
nikic
approved these changes
Jun 4, 2020
|
@beberlei Should be ready to merge now. ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids modifications to existing Zend APIs by providing attribute registration functions. This was suggested by @nikic in the attributes v2 PR. All the work is done by
zend_add_attribute()and some very small inline helper functions have been added tozend_attributes.hto deal with most common use cases.The compiler has been adjusted make use of the new API. The changes ensure that all attributes (and arrays) are allocated in
zend_attributes.c. This keeps the code in one place. It also enabled me to erasezend_attribute_free()from the public API because it is only needed internally.