Skip to content

Code Cleanup #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2020
Merged

Code Cleanup #16

merged 3 commits into from
May 28, 2020

Conversation

kooldev
Copy link

@kooldev kooldev commented May 28, 2020

Addresses most of the ToDo things in the RFC PR:

  • Opcache code has been simplified by removing unneeded checks and a call to efree().
  • AST dump has been restored (you inverted the desired newline behavior in your last commits).
  • Proper NULL-handling was added to getAttributes().
  • Added another child node to zend_ast_decl, attributes are always stored in child[4].
  • Moved some code around in the compiler to assert correct class scoping.
  • Added a closure scope and rebind test case.

@beberlei Ready to merge.

beberlei
beberlei approved these changes May 28, 2020
View reviewed changes
Copy link
Owner

@beberlei beberlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It amazes me how you do these internal move arounds seemingly easy :) looks awesome

@beberlei beberlei merged commit c643232 into beberlei:attributes_v2_rfc May 28, 2020
@kooldev kooldev deleted the Cleanup branch May 29, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beberlei beberlei beberlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kooldev @beberlei