Skip to content

Unify PhpCompilerAttribute + PhpAttribute; allow attributes on internal classes + fns #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2020
Merged

Unify PhpCompilerAttribute + PhpAttribute; allow attributes on internal classes + fns #14

merged 4 commits into from
May 23, 2020

Conversation

beberlei
Copy link
Owner

@beberlei beberlei commented May 23, 2020 •
edited
Loading

@kooldev Simplify and adds attributes on everything.

  • Removed PhpCompilerAttribute, each "compiler" attribute is just regular now.
  • Add attributes on internal classes
  • Add attributes on internal functions/methods
  • Add test showing that fetching attribues on PhpAttribute returns itself a PhpAttribute. Still failing, because it doesn't detect this properly on newInstance yet.
  • Add a compiler attribute example to zend_test

@beberlei beberlei changed the title Remove PhpCompilerAttribute, allow attributes on internal classes + fns Unify PhpCompilerAttribute + PhpAttribute; allow attributes on internal classes + fns May 23, 2020
@kooldev kooldev mentioned this pull request May 23, 2020
Merged
kooldev
kooldev reviewed May 23, 2020
View reviewed changes
Copy link

@kooldev kooldev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far. I added some comments mostly related to use of persistent memeory allocation. Letting go of compiler attribute is a good thing and supporting it on all internal classes / functions is also pretty nice.

kooldev
kooldev reviewed May 23, 2020
View reviewed changes
@nikic
Copy link

nikic commented May 23, 2020

You might want to add some additional tests in the zend_test extension.

@beberlei beberlei force-pushed the attributes_no_compiler_attribute branch from 8e93e4b to eb85f5a Compare May 23, 2020 09:57
@beberlei beberlei merged commit 66700f1 into attributes_v2_rfc May 23, 2020
@beberlei beberlei deleted the attributes_no_compiler_attribute branch May 23, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kooldev kooldev kooldev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beberlei @nikic @kooldev