Skip to content

More pythonic interface #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

perimosocordiae
Copy link

This is a big change, so feel free to take only the parts you like.

I converted the wrapper to a more "pythonic" interface by:

  • exposing a lot of the simple methods as read-only properties
  • simplifying the settings getters/setters
  • renaming methods to snake_case
  • making the data-filling functions a bit easier to understand/use

I updated the example programs to use the new API, so check out the diffs there to see how my changes affect usage.

The downside of all of this is that the new interface names are no longer a one-to-one mapping with the C++ ALE interface. The new names should hopefully make sense to someone who knows the C++ interface, though.

Updated the examples to reflect the new API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant