Skip to content

Improve TypeScript and linting setup #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 12, 2018
Merged

Improve TypeScript and linting setup #8

merged 10 commits into from
Mar 12, 2018

Conversation

skovhus
Copy link
Collaborator

@skovhus skovhus commented Mar 11, 2018 •
edited
Loading

A few suggestions to make the code a bit easier work with in terms of tooling. : ) The linting setup found a few minor issues.

In vscode I recommend installing tslint extension and adding "tslint.autoFixOnSave": true

mads-hartmann
mads-hartmann approved these changes Mar 12, 2018
View reviewed changes
Copy link
Collaborator

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks a lot @skovhus

@mads-hartmann mads-hartmann merged commit 2e4d6d9 into bash-lsp:master Mar 12, 2018
@skovhus skovhus deleted the improve-typescript-setup branch March 12, 2018 08:15
@renovate renovate bot mentioned this pull request Nov 16, 2022
Merged
1 task
@renovate renovate bot mentioned this pull request Feb 22, 2024
Closed
1 task
@vonschutter vonschutter mentioned this pull request Feb 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mads-hartmann mads-hartmann mads-hartmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skovhus @mads-hartmann