Skip to content

Do not crash if explainshell server is down or misconfigured #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2020

Conversation

skovhus
Copy link
Collaborator

@skovhus skovhus commented May 20, 2020

Fixes #61

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #238 into master will decrease coverage by 0.26%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   73.57%   73.30%   -0.27%     
==========================================
  Files          18       18              
  Lines         545      547       +2     
  Branches       87       87              
==========================================
  Hits          401      401              
- Misses        124      126       +2     
  Partials       20       20              
Impacted Files Coverage Δ
server/src/server.ts 61.67% <0.00%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d1dca...be9c3d1. Read the comment docs.

@skovhus skovhus merged commit 016291a into master May 20, 2020
@skovhus skovhus deleted the explainshell-exception branch May 20, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silently ignore the error when EXPLAINSHELL_ENDPOINT is unavailable
1 participant