Skip to content

Async fileread #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 16, 2020
Merged

Async fileread #213

merged 6 commits into from
Apr 16, 2020

Conversation

skovhus
Copy link
Collaborator

@skovhus skovhus commented Apr 16, 2020

Continuation of #212.

I did two quick measurements for analyzing 266 bash files.

Master: 2.2 / 1.9 seconds
After this branch: 1.6 / 1.8 seconds

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #213 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   70.04%   70.16%   +0.12%     
==========================================
  Files          18       18              
  Lines         474      476       +2     
  Branches       68       68              
==========================================
+ Hits          332      334       +2     
  Misses        125      125              
  Partials       17       17              
Impacted Files Coverage Δ
server/src/analyser.ts 73.41% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f11f305...8f77d43. Read the comment docs.

@skovhus skovhus merged commit 6858f2e into master Apr 16, 2020
@skovhus skovhus deleted the async-fileread branch April 16, 2020 11:53
@skovhus skovhus mentioned this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants