Skip to content

add PATH tilde expansion #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2019
Merged

add PATH tilde expansion #157

merged 2 commits into from
Dec 11, 2019

Conversation

ckjoris
Copy link

@ckjoris ckjoris commented Nov 11, 2019

implement #155

skovhus
skovhus reviewed Nov 11, 2019
View reviewed changes
Copy link
Collaborator

@skovhus skovhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good. I only have a minor comment.

@ckjoris
Copy link
Author

ckjoris commented Nov 12, 2019

yes, that code came from sindresorhus/untildify.
I added the comment, amended last commit. Please review.

rcjsuen
rcjsuen reviewed Nov 12, 2019
View reviewed changes
@dmerc @rcjsuen
Update server/src/util/fs.ts
4808707 
Co-Authored-By: Remy Suen <remy.suen@gmail.com>
mads-hartmann
mads-hartmann approved these changes Nov 13, 2019
View reviewed changes
Copy link
Collaborator

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A test of untildify would be lovely, but I don't consider it a blocker.

@skovhus skovhus merged commit 71068fa into bash-lsp:master Dec 11, 2019
@vonschutter vonschutter mentioned this pull request Feb 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skovhus skovhus skovhus left review comments

@rcjsuen rcjsuen rcjsuen left review comments

@mads-hartmann mads-hartmann mads-hartmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ckjoris @mads-hartmann @skovhus @rcjsuen @dmerc