Skip to content

Remove npm install step from VS Code extension #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 25, 2019
Merged

Conversation

skovhus
Copy link
Collaborator

@skovhus skovhus commented Sep 24, 2019

Here we are removing the npm install step by including the new wasm version of the LSP server into the VS Code extension.

I combined some work I did back in June (https://github.com/mads-hartmann/bash-language-server/pull/134/commits) and work done a year ago (#72).

Related to #131

TODO

  • combine server with vscode client
  • test on OS X
  • test on Windows
  • documentation

Note on how to test:

cd vscode-client && vsce package --yarn
code --install-extension <path to package.vix>

@skovhus
Copy link
Collaborator Author

skovhus commented Sep 24, 2019

@mads-hartmann can you try it out by uninstalling bash-language-server (npm -g uninstall bash-language-server) and run:

cd vscode-client && vsce package --yarn
code --install-extension <path to package.vix>

@skovhus skovhus mentioned this pull request Sep 24, 2019
@mads-hartmann
Copy link
Collaborator

@skovhus Just gave it a go. It works 🎉

@skovhus skovhus merged commit 2488754 into master Sep 25, 2019
@skovhus skovhus deleted the remove-install-step branch September 25, 2019 20:43
@skovhus
Copy link
Collaborator Author

skovhus commented Dec 11, 2019

@mads-hartmann we should release the vscode extension :)

The version number is bumped, so we just need to run the release step. Can you do that?

@mads-hartmann
Copy link
Collaborator

@skovhus Done, works like a charm 🎉

@skovhus
Copy link
Collaborator Author

skovhus commented Dec 13, 2019

NICE! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants