Run yarn run lint. #123
Closed
Run yarn run lint. #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes done by lint. Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
|
Linting is ensured by CI for all commits. This PR actually failed because the changes made doesn’t not lint correctly. It seems you might be using a different tslint or prettier version. Can you remove nose_modules and see if that solves the issue? |
|
I removed node_modules and got the same results. Anything else you want me to try ? |
|
Never mind. I haven't reverted last commit and yarn run lint actually bringed it to the master version. Sorry for the noise. |
|
No problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done by lint.
Signed-off-by: Alexander Kurtakov akurtako@redhat.com