Update release-client.sh script #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't actually have a way to test this, but I think it should be okay If you disagree with this, feel free to close, but I thought it might be a good idea 😄 Thanks for reviewing! |
This comment was marked as outdated.
This comment was marked as outdated.
Jimmyscene
changed the title
Update vscde to latest version (vsce is depresated in favor of @vscode/vsce) Add --skip-duplicate flag, this allows us to fail silently if the version already exists on the marketplace, which was why we had the "|| echo" before, but it also hid real failures, so IMO this is a better way to handle that Also update snapshot, since I moved `tagRelease` to the next line, one of the tests failed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 28 28
Lines 1348 1348
Branches 320 320
=======================================
Hits 1099 1099
Misses 204 204
Partials 45 45 ☔ View full report in Codecov by Sentry. |
Jimmyscene
changed the title
skovhus
reviewed
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update vscde to latest version (vsce is depresated in favor of @vscode/vsce)
The current code has an
|| echothat masks failures from vsce publish, in order to not fail the pipeline when the published version already exists.The latest version of vsce adds a --skip-duplicate flag, this allows us to fail silently if the version already exists on the marketplace, so IMO this is a better way to handle that