Windows support

[asampal]

Seeing this when I switch to a bash file, in Visual Studio Code 1.20.1, Windows 10, extension v. 1.1.4:

module.js:672
  return process.dlopen(module, path._makeLong(filename));
                 ^

Error: \\?\C:\Users\asampaleanu\.vscode\extensions\mads-hartmann.bash-ide-vscode-1.1.4\server\node_modules\tree-sitter\build\Release\tree_sitter_runtime_binding.node is not a valid Win32 application\\?\C:\Users\asampaleanu\.vscode\extensions\mads-hartmann.bash-ide-vscode-1.1.4\server\node_modules\tree-sitter\build\Release\tree_sitter_runtime_binding.node
    at Object.Module._extensions..node (module.js:672:18)
    at Module.load (module.js:556:32)
    at tryModuleLoad (module.js:499:12)
    at Function.Module._load (module.js:491:3)
    at Module.require (module.js:587:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (C:\Users\asampaleanu\.vscode\extensions\mads-hartmann.bash-ide-vscode-1.1.4\server\node_modules\tree-sitter\index.js:1:125)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)
    at Module.load (module.js:556:32)
[Info  - 9:28:54 AM] Connection to server got closed. Server will restart.
module.js:672
  return process.dlopen(module, path._makeLong(filename));

[mads-hartmann]

@asampal Thanks, I believe I know how to fix this. I've accidentally shipped an OS X binary I believe ;)

[asampal]

Great - looking forward to the fix.

[mads-hartmann]

@asampal Could you try installing version 1.1.6? I believe I've fixed the issue ☺️

[mads-hartmann]

@asampal Please reopen if you're still having issues 🙂

[asampal]

I'm still seeing the same problem @mads-hartmann . Should the Windows binary be built automatically when the extension is installed? The error message is exactly the same, so it looks like the extension is still somehow not building for Windows.

[asampal]

Could it be that my system is somehow being detected as running OS X?

[mads-hartmann]

@asampal Turns out it's a bit more complicated to ship an extension that has native dependencies than I thought 🙂I found this guide that I'll try to follow.

[mads-hartmann]

@asampal I'm trying a different approach. Can you run npm i -g bash-language-server for me to see if the server installs on your system. And if it does, can you then try running bash-language-server -h to see if it executes properly?

[asampal]

I get this when I try to install the language server:

adi@VESUVIUS C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter                                                                                                                                
$ if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "C:\Program Files\nodejs\node_modules\n
pm\node_modules\node-gyp\bin\node-gyp.js" rebuild )                                                                                                                                                                                     
Warning: Missing input files:                                                                                                                                                                                                           
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\prepare_grammar\expand_tokens.cc                                          
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\syntax_grammar.cc                                                         
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\prepare_grammar\token_description.cc                                      
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\build_tables\lookahead_set.cc                                             
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\build_tables\lex_item_transitions.cc                                      
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\prepare_grammar\expand_repeats.cc                                         
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\parse_table.cc                                                            
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\externals\json-parser\json.c                                                           
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\prepare_grammar\extract_choices.cc                                        
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\prepare_grammar\normalize_rules.cc                                        
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\rules\character_set.cc                                                    
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\generate_code\c_code.cc                                                   
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\prepare_grammar\extract_tokens.cc                                         
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\prepare_grammar\flatten_grammar.cc                                        
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\prepare_grammar\intern_symbols.cc                                         
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\rules\choice.cc                                                           
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\prepare_grammar\prepare_grammar.cc                                        
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\build_tables\lex_table_builder.cc                                         
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\rules\metadata.cc                                                         
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\rule.cc                                                                   
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\lex_table.cc                                                              
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\build_tables\lex_item.cc                                                  
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\build_tables\parse_table_builder.cc                                       
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\build_tables\parse_item.cc                                                
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\compile.cc                                                                
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\build_tables\parse_item_set_builder.cc                                    
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\rules\repeat.cc                                                           
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\rules\seq.cc                                                              
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\prepare_grammar\parse_regex.cc                                            
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\build_tables\rule_can_be_blank.cc                                         
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\util\string_helpers.cc                                                    
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\precedence_range.cc                                                       
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\build_tables\lex_conflict_manager.cc                                      
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\..\..\..\vendor\tree-sitter\src\compiler\parse_grammar.cc                                                          
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.                                                                                                                             
C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter\build\vendor\tree-sitter\runtime.vcxproj(28,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Default.props" was not found. Confirm 
 that the path in the <Import> declaration is correct, and that the file exists on disk.                                                                                                                                                
gyp ERR! build error                                                                                                                                                                                                                    
gyp ERR! stack Error: `C:\Windows\Microsoft.NET\Framework\v4.0.30319\msbuild.exe` failed with exit code: 1                                                                                                                              
gyp ERR! stack     at ChildProcess.onExit (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\build.js:258:23)                                                                                                          
gyp ERR! stack     at ChildProcess.emit (events.js:127:13)                                                                                                                                                                              
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:209:12)                                                                                                                                            
gyp ERR! System Windows_NT 10.0.16299                                                                                                                                                                                                   
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"                                                                               
gyp ERR! cwd C:\Users\adi\AppData\Roaming\npm\node_modules\bash-language-server\node_modules\tree-sitter                                                                                                                                
gyp ERR! node -v v9.6.1                                                                                                                                                                                                                 
gyp ERR! node-gyp -v v3.6.2                                                                                                                                                                                                             
gyp ERR! not ok                                                                                                                                                                                                                         
npm ERR! code ELIFECYCLE                                                                                                                                                                                                                
npm ERR! errno 1                                                                                                                                                                                                                        
npm ERR! tree-sitter@0.9.2 install: `node-gyp rebuild`                                                                                                                                                                                  
npm ERR! Exit status 1                                                                                                                                                                                                                  
npm ERR!                                                                                                                                                                                                                                
npm ERR! Failed at the tree-sitter@0.9.2 install script.                                                                                                                                                                                
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.                                                                                                                                      
                                                                                                                                                                                                                                        
npm ERR! A complete log of this run can be found in:                                                                                                                                                                                    
npm ERR!     C:\Users\adi\AppData\Roaming\npm-cache\_logs\2018-03-03T21_03_30_599Z-debug.log                                                                                                                                            

[asampal]

The full log is for the above is:

2018-03-03T21_03_30_599Z-debug.log

I had already installed node-gyp as per, instructions, along with it's dependency of the Microsoft Build Tools (for VS 20017).

[asampal]

Maybe you could, at least as an option, use the WSL (Windows Subsystem for Linux) for what you need to do. Since the Fall Creators Update it's quite interoperable with Windows. Some of the files here might be of help.