shellcheck: forcing to work with zsh does not work

[chrisgrieser]

Code editor

nvim

Platform

macOS 14.1 (arm)

Version

5.0.0

What steps will reproduce the bug?

shell file with zsh shebang and an issue that shellcheck will reprot:

#!/usr/bin/env bash
cat foo | grep "foobar"
# here shellcheck reports an issue

#!/usr/bin/env zsh
cat foo | grep "foobar"
# here it does not

How often does it reproduce? Is there a required condition?

always

What is the expected behavior?

When using shellcheck, you can actually force it to check zsh files by adding --shell=bash. While not perfect, it's still useful.

However, when passing bashIde.shellcheckArguments = "--shell=bash", bashls still refuses to lint files with a zsh shebang. I assume there is something in the bashls source-code which stops shellcheck from working on zsh files, even if it nromally works in shellcheck.

What do you see instead?

shellcheck not working as soon as you add a zsh-shebang

Additional information

• related issue: The "shell" directive has no effect in a shell script file #929
• potential cause? Add "--shell=bash" argument for ShellCheck #536

[skovhus]

Contributions are more than welcome.

[0xdevalias]

Context for the close/reopen:

skovhus Sorry to bother you again, but it seems this PR did not fix the issue.

The problem described in #1064 still occurs, and shellcheck does not become active in a zsh file, even if passing bashIde.shellcheckArguments = "--shell=bash". I assume the problem is that the LS somehow still does not enable shellcheck until it is a bash file?

Originally posted by @chrisgrieser in #1133 (comment)