This repository was archived by the owner on May 21, 2025. It is now read-only.
fiberlamda: fix the tests by removing gzip checks #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fasthttp automatically handles Transfer-Encoding header so our expectations of having this header in the fiber request context were failing. https://github.com/valyala/fasthttp/blob/master/header.go#L1292
This was referenced Jun 11, 2022
|
Oh, really thanks. It's my mistake. Would you check this PR? @ReneWerner87 |
|
Hi, @iamsalnikov Would you check this PR, I think.. it's duplicated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fasthttp automatically handles Transfer-Encoding header so our expectations of having this header in the fiber request context were failing.
https://github.com/valyala/fasthttp/blob/master/header.go#L1292
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.