Skip to content

Bugfix/fix minor documentation issues #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ChristianUlbrich
Copy link
Contributor

@ChristianUlbrich ChristianUlbrich commented Aug 21, 2024

Fixes Issue #202, #115.

Description of changes:

  • update README.md and some minor code examples to be consistent again, with current AWS infrastructure
    1. fix provided runtime to provided.al2023
    2. add missing --cli-binary-format raw-in-base64-out to make example work with current AWS CLI@2
    3. add hint on arm64 architecture
    4. fix example to use proper JSON (json payload here is not valid JSON)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* provided has to be either provided.al2023 or provided.al2
* AWS CLI2 has changed the param format
* add docs about building on arm64
* use proper JSON in example
* add hint on how to update example Lambda
@maxday
Copy link
Contributor

maxday commented Apr 29, 2025

Thanks a lot @ChristianUlbrich and very sorry about the delay

@maxday maxday self-requested a review April 29, 2025 09:15
Copy link

@godcrampy godcrampy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@maxday maxday merged commit 074d122 into awslabs:master Apr 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants