Optimizations #100
Merged
Optimizations #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcomagdy
force-pushed
the
optimizations
branch
from
39f1e36 to
93a48e8
Compare
Adding rvalue ref-qualifiers to the 'outcome' class getters enables moving out the result instead of copying it. In this case, we can avoid copying the request payload.
marcomagdy
force-pushed
the
optimizations
branch
from
93a48e8 to
b572d42
Compare
static inline makes no sense in a header file.
dislogical
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid copying the result of the 'outcome' class.
Adding rvalue ref-qualifiers to the 'outcome' class getters enables
moving out the result instead of copying it. In this case, we can avoid
copying the request payload.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.