More linter issues

Author: Marco Magdy

include/aws/http/response.h

@@ -31,12 +31,12 @@ class response {
      * lower-case the name but store the value as is
      */
     inline void add_header(std::string name, std::string const& value);
-    inline void append_body(const char* p, size_t sz);
+    inline void append_body(const char* payload, size_t payload_size);
     inline bool has_header(char const* header) const;
     inline lambda_runtime::outcome<std::string, bool> get_header(char const* header) const;
     inline response_code get_response_code() const { return m_response_code; }
-    inline void set_response_code(aws::http::response_code c);
-    inline void set_content_type(char const* ct);
+    inline void set_response_code(aws::http::response_code code);
+    inline void set_content_type(char const* content);
     inline std::string const& get_body() const;
 
 private:
@@ -125,14 +125,14 @@ enum class response_code {
     NETWORK_CONNECT_TIMEOUT = 599
 };
 
-inline void response::set_response_code(http::response_code c)
+inline void response::set_response_code(http::response_code code)
 {
-    m_response_code = c;
+    m_response_code = code;
 }
 
-inline void response::set_content_type(char const* ct)
+inline void response::set_content_type(char const* content_type)
 {
-    m_content_type = ct;
+    m_content_type = content_type;
 }
 
 inline std::string const& response::get_body() const
@@ -145,34 +145,34 @@ inline void response::add_header(std::string name, std::string const& value)
     m_headers.emplace_back(std::move(name), value);
 }
 
-inline void response::append_body(const char* p, size_t sz)
+inline void response::append_body(const char* payload, size_t payload_size)
 {
     // simple and generates significantly less code than std::stringstream
     constexpr size_t min_capacity = 512;
     if (m_body.capacity() < min_capacity) {
         m_body.reserve(min_capacity);
     }
 
-    m_body.append(p, sz);
+    m_body.append(payload, payload_size);
 }
 
 inline bool response::has_header(char const* header) const
 {
-    return std::any_of(m_headers.begin(), m_headers.end(), [header](std::pair<std::string, std::string> const& p) {
-        return p.first == header;
+    return std::any_of(m_headers.begin(), m_headers.end(), [header](std::pair<std::string, std::string> const& item) {
+        return item.first == header;
     });
 }
 
 inline lambda_runtime::outcome<std::string, bool> response::get_header(char const* header) const
 {
-    auto it = std::find_if(m_headers.begin(), m_headers.end(), [header](std::pair<std::string, std::string> const& p) {
-        return p.first == header;
+    auto iter = std::find_if(m_headers.begin(), m_headers.end(), [header](std::pair<std::string, std::string> const& item) {
+        return item.first == header;
     });
 
-    if (it == m_headers.end()) {
+    if (iter == m_headers.end()) {
         return false;
     }
-    return it->second;
+    return iter->second;
 }
 
 } // namespace http

include/aws/lambda-runtime/outcome.h

@@ -23,11 +23,11 @@ namespace lambda_runtime {
 template <typename TResult, typename TFailure>
 class outcome {
 public:
-    outcome(TResult const& s) : m_s(s), m_success(true) {}
-    outcome(TResult&& s) : m_s(std::move(s)), m_success(true) {}
+    outcome(TResult const& success) : m_s(success), m_success(true) {}
+    outcome(TResult&& success) : m_s(std::move(success)), m_success(true) {}
 
-    outcome(TFailure const& f) : m_f(f), m_success(false) {}
-    outcome(TFailure&& f) : m_f(std::move(f)), m_success(false) {}
+    outcome(TFailure const& failure) : m_f(failure), m_success(false) {}
+    outcome(TFailure&& failure) : m_f(std::move(failure)), m_success(false) {}
 
     outcome(outcome const& other) : m_success(other.m_success)
     {

include/aws/logging/logging.h

@@ -25,7 +25,7 @@ enum class verbosity {
     debug,
 };
 
-void log(verbosity v, char const* tag, char const* msg, va_list args);
+void log(verbosity verbosity, char const* tag, char const* msg, va_list args);
 
 [[gnu::format(printf, 2, 3)]] inline void log_error(char const* tag, char const* msg, ...)
 {