Fix clang-tidy benign warnings

Made the variables 3 characters or more.
Disabled the parameters easily swappable warning because there isn't an
easy way to fix that in C++ without introducing another library or a lot
of boilerplate code. The code is small enough to not warrant introducing
solutions to avoid that warnings.

Author: Marco Magdy

.clang-tidy

@@ -1,6 +1,7 @@
 ---
 Checks:
-'clang-diagnostic-*,clang-analyzer-*,performance-*,readability-*,modernize-*,bugprone-*,misc-*,-modernize-use-trailing-return-type'
+'clang-diagnostic-*,clang-analyzer-*,performance-*,readability-*,modernize-*,bugprone-*,misc-*,
+-modernize-use-trailing-return-type,-bugprone-easily-swappable-parameters'
 WarningsAsErrors: '*'
 HeaderFilterRegex: 'include/aws/.*\.h$'
 FormatStyle: 'none'

src/logging.cpp

@@ -22,9 +22,9 @@
 namespace aws {
 namespace logging {
 
-static inline char const* get_prefix(verbosity v)
+static inline char const* get_prefix(verbosity verbosity)
 {
-    switch (v) {
+    switch (verbosity) {
         case verbosity::error:
             return "[ERROR]";
         case verbosity::info:
@@ -37,28 +37,28 @@ static inline char const* get_prefix(verbosity v)
 }
 
 LAMBDA_RUNTIME_API
-void log(verbosity v, char const* tag, char const* msg, va_list args)
+void log(verbosity verbosity, char const* tag, char const* msg, va_list args)
 {
     va_list copy;
     va_copy(copy, args);
-    const int sz = vsnprintf(nullptr, 0, msg, args) + 1;
-    if (sz < 0) {
+    const int msg_size = vsnprintf(nullptr, 0, msg, args) + 1;
+    if (msg_size < 0) {
         puts("error occurred during log formatting!\n");
         va_end(copy);
         return;
     }
     constexpr int max_stack_buffer_size = 512;
     std::array<char, max_stack_buffer_size> buf;
     char* out = buf.data();
-    if (sz >= max_stack_buffer_size) {
-        out = new char[sz];
+    if (msg_size >= max_stack_buffer_size) {
+        out = new char[msg_size];
     }
 
-    vsnprintf(out, sz, msg, copy);
+    vsnprintf(out, msg_size, msg, copy);
     va_end(copy);
-    auto ms = std::chrono::duration_cast<std::chrono::milliseconds>(
+    auto millis = std::chrono::duration_cast<std::chrono::milliseconds>(
         std::chrono::high_resolution_clock::now().time_since_epoch());
-    printf("%s [%lld] %s %s\n", get_prefix(v), static_cast<long long>(ms.count()), tag, out);
+    printf("%s [%lld] %s %s\n", get_prefix(verbosity), static_cast<long long>(millis.count()), tag, out);
     // stdout is not line-buffered when redirected (for example to a file or to another process) so we must flush it
     // manually.
     fflush(stdout);