Skip to content

Add support for Jenkins Pipeline #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Conversation

DDRBoxman
Copy link

Cleaned up the commit from @ansoni in hope of getting this merged.

@nwalke
Copy link

nwalke commented Aug 14, 2017

@Suryanarayanan Can we get this merged soon? The pipeline support PRs have been sitting around for quite a while.

@p1c2u
Copy link

p1c2u commented Oct 12, 2017

+1

import hudson.model.BuildListener;
import hudson.model.AbstractProject;
import hudson.model.Result;
import hudson.*;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should explicitly import the class we need instead.

Copy link

@naveedahmedsiddiqui naveedahmedsiddiqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see a minor comment I made. Also please acknowledge the license agreement for code change:

'This plugin is licensed under Apache 2.0. See the LICENSE file for more information.'

@DDRBoxman
Copy link
Author

This code is released under Apache 2.0

@cfoehrdes
Copy link

Can we provide any help to get this feature merged in the near future?

@DDRBoxman
Copy link
Author

Apparently, the team in charge of this changed recently. Amazon said that it might be at least another week till someone looks at it.

@Jmcfar
Copy link
Contributor

Jmcfar commented Dec 19, 2017

Hi!

Thanks for the contribution.

Did you perform any testing as part of the changes? If so it'd be helpful to include that in the PR.

@Jmcfar Jmcfar self-assigned this Dec 19, 2017
@Jmcfar Jmcfar merged commit 716aa3e into awslabs:master Dec 20, 2017
@Jmcfar
Copy link
Contributor

Jmcfar commented Dec 20, 2017

Manually did testing on our end for both new pipelines support and older style behavior so going to merge this in. Thanks for the contribution!

@Jmcfar
Copy link
Contributor

Jmcfar commented Dec 20, 2017

This has been published to the Jenkins plugin repository. Updating to the CodeDeploy plugin 1.19 or later should enable Pipeline support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants