-
Notifications
You must be signed in to change notification settings - Fork 132
Add support for Jenkins Pipeline #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Suryanarayanan Can we get this merged soon? The pipeline support PRs have been sitting around for quite a while. |
+1 |
import hudson.model.BuildListener; | ||
import hudson.model.AbstractProject; | ||
import hudson.model.Result; | ||
import hudson.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should explicitly import the class we need instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see a minor comment I made. Also please acknowledge the license agreement for code change:
'This plugin is licensed under Apache 2.0. See the LICENSE file for more information.'
This code is released under Apache 2.0 |
Can we provide any help to get this feature merged in the near future? |
Apparently, the team in charge of this changed recently. Amazon said that it might be at least another week till someone looks at it. |
Hi! Thanks for the contribution. Did you perform any testing as part of the changes? If so it'd be helpful to include that in the PR. |
Manually did testing on our end for both new pipelines support and older style behavior so going to merge this in. Thanks for the contribution! |
This has been published to the Jenkins plugin repository. Updating to the CodeDeploy plugin 1.19 or later should enable Pipeline support. |
Cleaned up the commit from @ansoni in hope of getting this merged.