[Lambda] Replace Facade with No-Op if trace header is missing data #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #651 +/- ##
==========================================
- Coverage 83.49% 82.80% -0.70%
==========================================
Files 37 37
Lines 1806 1855 +49
==========================================
+ Hits 1508 1536 +28
- Misses 298 319 +21 ☔ View full report in Codecov by Sentry. |
wangzlei
reviewed
Jun 4, 2024
wangzlei
added a commit
that referenced
this pull request
Jun 6, 2024
Revert #651 [Lambda] Replace Facade with No-Op if trace header is missing data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support Root Lambda PassThrough, we want to have a no-op segment when PassThrough mode is enabled to allow for SDK to have its functionalities disabled for the given segment. The following tests were done using two lambda functions, A and B, where A calls B.
Lambda A PassThrough calling Prod Lambda B Active:
Root=1-665a0c0c-2420a39e4fca953752e2e9f4;Lineage=061379e8:0Root=1-665a0c0c-2420a39e4fca953752e2e9f4;Parent=8c885bca7ccc2033;Sampled=1;Lineage=061379e8:0|cbc84ad3:0Lambda A Active calling Prod Lambda B Active:
Root=1-665a39a0-7e53f00f3b1da8ad70666729;Parent=ce7fe8bbc2783986;Sampled=1;Lineage=061379e8:0Root=1-665a39a0-7e53f00f3b1da8ad70666729;Parent=e80ec591cab089eb;Sampled=1;Lineage=061379e8:0|cbc84ad3:0By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.