Fix sync-over-async in DynamoDBRetryPolicy.
#3842
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
changed the title
DynamoDBRetryPolicy.DynamoDBRetryPolicy.
dscpinheiro
reviewed
May 27, 2025
sdk/src/Services/DynamoDBv2/Custom/Internal/DynamoDBRetryPolicy.cs
Outdated
Show resolved
Hide resolved
teo-tsirpanis
force-pushed
the
ddb-async-retry
branch
from
4675c8d to
b4853a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
DynamoDBRetryPolicyto override theWaitBeforeRetryAsyncmethod in order to not synchronously block when retrying asynchronous DynamoDB operations. This improves scalability and thread utilization.Motivation and Context
Noticed as part of a larger clean-up effort, and split into its own branch.
Testing
N/A
Screenshots (if appropriate)
Types of changes
Checklist
License