-
Notifications
You must be signed in to change notification settings - Fork 910
Add Environment Token support #6130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
alextwoods
wants to merge
26
commits into
rvaknin/auth-schem-preference-config
Choose a base branch
from
alexwoo/env-token-provider
base: rvaknin/auth-schem-preference-config
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
e2e2fbf
Prototype implementation of Auth Scheme Preference
alextwoods 6790d42
Add tracking of explictly set token provider
alextwoods b894b88
Use generated PreferredAuthSchemeProvider to wrap/delegate
alextwoods 2bdaac7
Add generic-service environment token provider + customization config…
alextwoods f72dac1
Use generated PreferredAuthSchemeProvider to wrap/delegate
alextwoods 7cc52ee
Merge branch 'alexwoo/configure-auth-preference' into alexwoo/bedrock…
alextwoods 26b8fda
Include tokenProvider in service config when bearer is on the model
alextwoods 14682dc
Support sourcing token from jvm settings + env variable.
alextwoods a6a1346
Refactor + use namingStrategy + add tests
alextwoods 60165c1
Set business metric using an interceptor
alextwoods 8feab9e
Add ability to override token provider on request
alextwoods 345bb93
Fix checkstyle on prefered auth scheme provider
alextwoods e55fe52
Add validation of service+customization
alextwoods 1849a83
Refactor env token customizaiton logic + add more tests
alextwoods e834b54
Testing and cleanup
alextwoods 2090d04
Merge branch 'master' into alexwoo/env-token-provider
alextwoods badc138
Merge branch 'master' into alexwoo/env-token-provider
alextwoods a85dace
Merge branch 'rvaknin/auth-schem-preference-config' into alexwoo/env-…
alextwoods c4b6fbd
Add changelog
alextwoods 48784f5
Minor cleanups
alextwoods 430e335
Merge branch 'rvaknin/auth-schem-preference-config' into alexwoo/env-…
alextwoods ca2faac
Refactor and cleanup - move anon classes to full codegen classes.
alextwoods f3992dc
Update docs
alextwoods 7a8bfa0
Additional codegen tests
alextwoods 10c5e4f
Update core/aws-core/src/main/java/software/amazon/awssdk/awscore/int…
alextwoods e9afd67
Add codegen tset for base client builder w/ env bearer token
alextwoods File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"type": "feature", | ||
"category": "AWS SDK for Java v2", | ||
"contributor": "", | ||
"description": "Adds support for configuring bearer auth using a token sourced from the environment for services with the `enableEnvironmentBearerToken` customization flag." | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 94 additions & 0 deletions
94
...a/software/amazon/awssdk/codegen/poet/client/EnvironmentTokenMetricsInterceptorClass.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,94 @@ | ||
/* | ||
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* A copy of the License is located at | ||
* | ||
* http://aws.amazon.com/apache2.0 | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed | ||
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
* express or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
package software.amazon.awssdk.codegen.poet.client; | ||
|
||
import com.squareup.javapoet.ClassName; | ||
import com.squareup.javapoet.MethodSpec; | ||
import com.squareup.javapoet.TypeSpec; | ||
import javax.lang.model.element.Modifier; | ||
import software.amazon.awssdk.annotations.SdkInternalApi; | ||
import software.amazon.awssdk.codegen.model.intermediate.IntermediateModel; | ||
import software.amazon.awssdk.codegen.poet.ClassSpec; | ||
import software.amazon.awssdk.codegen.poet.PoetExtension; | ||
import software.amazon.awssdk.codegen.poet.PoetUtils; | ||
import software.amazon.awssdk.core.SelectedAuthScheme; | ||
import software.amazon.awssdk.core.interceptor.Context; | ||
import software.amazon.awssdk.core.interceptor.ExecutionAttributes; | ||
import software.amazon.awssdk.core.interceptor.ExecutionInterceptor; | ||
import software.amazon.awssdk.core.interceptor.SdkInternalExecutionAttribute; | ||
import software.amazon.awssdk.core.useragent.BusinessMetricFeatureId; | ||
import software.amazon.awssdk.http.auth.scheme.BearerAuthScheme; | ||
import software.amazon.awssdk.identity.spi.TokenIdentity; | ||
|
||
public class EnvironmentTokenMetricsInterceptorClass implements ClassSpec { | ||
protected final PoetExtension poetExtensions; | ||
|
||
public EnvironmentTokenMetricsInterceptorClass(IntermediateModel model) { | ||
this.poetExtensions = new PoetExtension(model); | ||
} | ||
|
||
|
||
@Override | ||
public TypeSpec poetSpec() { | ||
return TypeSpec.classBuilder(className()) | ||
.addModifiers(Modifier.PUBLIC) | ||
.addAnnotation(PoetUtils.generatedAnnotation()) | ||
.addAnnotation(SdkInternalApi.class) | ||
.addSuperinterface(ExecutionInterceptor.class) | ||
.addField(String.class, "tokenFromEnv", Modifier.PRIVATE, Modifier.FINAL) | ||
.addMethod(constructor()) | ||
.addMethod(beforeExecutionMethod()) | ||
.build(); | ||
} | ||
|
||
private MethodSpec constructor() { | ||
return MethodSpec.constructorBuilder() | ||
.addModifiers(Modifier.PUBLIC) | ||
.addParameter(String.class, "tokenFromEnv") | ||
.addStatement("this.tokenFromEnv = tokenFromEnv") | ||
.build(); | ||
} | ||
|
||
@Override | ||
public ClassName className() { | ||
return poetExtensions.getEnvironmentTokenMetricsInterceptorClass(); | ||
} | ||
|
||
private MethodSpec beforeExecutionMethod() { | ||
return MethodSpec | ||
.methodBuilder("beforeExecution") | ||
.addAnnotation(Override.class) | ||
.addModifiers(Modifier.PUBLIC) | ||
.addParameter(Context.BeforeExecution.class, "context") | ||
.addParameter(ExecutionAttributes.class, "executionAttributes") | ||
.addStatement("$T<?> selectedAuthScheme = executionAttributes.getAttribute($T.SELECTED_AUTH_SCHEME)", | ||
SelectedAuthScheme.class, SdkInternalExecutionAttribute.class) | ||
.beginControlFlow("if (selectedAuthScheme != null && selectedAuthScheme.authSchemeOption().schemeId().equals($T" | ||
+ ".SCHEME_ID) && selectedAuthScheme.identity().isDone())", BearerAuthScheme.class) | ||
.beginControlFlow("if (selectedAuthScheme.identity().getNow(null) instanceof $T)", TokenIdentity.class) | ||
|
||
.addStatement("$T configuredToken = ($T) selectedAuthScheme.identity().getNow(null)", | ||
TokenIdentity.class, TokenIdentity.class) | ||
.beginControlFlow("if (configuredToken.token().equals(tokenFromEnv))") | ||
.addStatement("executionAttributes.getAttribute($T.BUSINESS_METRICS)" | ||
+ ".addMetric($T.BEARER_SERVICE_ENV_VARS.value())", | ||
SdkInternalExecutionAttribute.class, BusinessMetricFeatureId.class) | ||
.endControlFlow() | ||
.endControlFlow() | ||
.endControlFlow() | ||
.build(); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a codegenerated test class to see what this looks like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added, see:
test-env-bearer-token-client-builder-class.java
(in particular here)