Update non-streaming error unmarshaller with the new mapping function #6122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
requested changes
May 20, 2025
| .shardIterator("Invalid-Shard-Iterator") | ||
| .build(); | ||
|
|
||
| client.getRecords(request); |
There was a problem hiding this comment.
Let's use assertThatThrownBy instead.
There was a problem hiding this comment.
Done, updated the tests.
| .shardIterator("NonExistent-Shard-Iterator") | ||
| .build(); | ||
|
|
||
| client.getRecords(request); |
davidh44
approved these changes
May 20, 2025
|
Approved previously in earlier PR : #5991 Approving, pending test changes requested by Zoe |
|
zoewangg
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update non-streaming error unmarshalling with the new mapping function.
Motivation and Context
This change updates the non-streaming error unmarshalling to use the same mapping function that was previously implemented for streaming operations. This change deprecates BaseAwsJsonProtocolFactory#createErrorResponseHandler(JsonOperationMetadata). We have switched all usages in generated code to the replacement, createErrorResponseHandler(JsonOperationMetadata,Function).
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License