Skip to content

Set explicit payload members to null if the input is empty #6111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025

Conversation

sugmanue
Copy link
Contributor

Motivation and Context

Fixes a regression for the REST JSON protocol. Before a explicit payload member of the response was unmarshalled as null when the response body was empty, and after enabling the fast JSON unmarshaller this behavior changed to unmarshall it as an POJO without any members set.

This change reverts to the previous behavior and now the member is unmarshalled as null.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@sugmanue sugmanue marked this pull request as ready for review May 15, 2025 19:04
@sugmanue sugmanue requested a review from a team as a code owner May 15, 2025 19:04
@sugmanue sugmanue enabled auto-merge May 15, 2025 20:00
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
73.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sugmanue sugmanue added this pull request to the merge queue May 15, 2025
Merged via the queue into master with commit 3ec934d May 15, 2025
20 of 21 checks passed
@sugmanue sugmanue deleted the sugmanue/fix-explicit-payload-members-unmarshalling branch May 15, 2025 21:56
@sugmanue
Copy link
Contributor Author

Protocol tests for Smithy for this case is pending review, see #2641.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants