Update EC2MetadataUtilServer to only accept localhost address #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunnvs92
approved these changes
Jan 30, 2018
dagnir
reviewed
Jan 30, 2018
| throws UnknownHostException, IOException { | ||
| server = new ServerSocket(port, 1, InetAddress.getByName(address)); | ||
| server = new ServerSocket(port, 1, InetAddress.getByName("localhost")); |
There was a problem hiding this comment.
should we connect directly to 127.0.0.1 instead so there's no lookup?
There was a problem hiding this comment.
Apprently getLocalHost() is actually kinda misleading and doesn't return the address of localhost: https://stackoverflow.com/a/18488982
Looking at it again, I think what you had originally is fine.
There was a problem hiding this comment.
yeah, actually, InetAddress.getLoopbackAddress() is what we want.
zoewangg
force-pushed
the
UpdateEC2MetadataUtilsServer
branch
2 times, most recently
from
a21203b to
14e1351
Compare
zoewangg
force-pushed
the
UpdateEC2MetadataUtilsServer
branch
from
14e1351 to
0407f3d
Compare
dagnir
approved these changes
Jan 30, 2018
aws-sdk-java-automation
pushed a commit
that referenced
this pull request
Feb 7, 2019
…59713989 Pull request: release <- staging/50a2295d-2367-4909-b2ae-ab1759713989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update EC2MetadataUtilServer to only accept localhost address