Fixed bug where using profile-based credentials could cause the SDK to read the profile file with each request. #3950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o read the profile file with each request. This bug was introduced with the profile file supplier changes. If the customer was not overriding the profile file via the client override config AND was relying on profile file-based configuration, that configuration would be read with every request. This had a significant performance cost. ``` Benchmarking Results (software.amazon.awssdk.benchmark.apicall.protocol.JsonProtocolBenchmark) Before: 2858.805 ± 181.491 ops/s After: 10915.079 ± 677.022 ops/s ```
|
Kudos, SonarCloud Quality Gate passed! |
cenedhryn
reviewed
Apr 25, 2023
| @@ -264,9 +264,9 @@ protected SdkClientConfiguration mergeChildDefaults(SdkClientConfiguration confi | |||
| */ | |||
| private SdkClientConfiguration mergeGlobalDefaults(SdkClientConfiguration configuration) { | |||
| // Don't load the default profile file if the customer already gave us one. | |||
| Supplier<ProfileFile> configuredProfileFileSupplier = configuration.option(PROFILE_FILE_SUPPLIER); | |||
| Supplier<ProfileFile> profileFileSupplier = Optional.ofNullable(configuredProfileFileSupplier) | |||
| .orElseGet(() -> ProfileFile::defaultProfileFile); | |||
There was a problem hiding this comment.
Where does the potential read-every-request happen?
There was a problem hiding this comment.
We call get() on the supplier for every request. The supplier used to be ProfileFile::defaultProfileFile, which reads the file when it is called.
There was a problem hiding this comment.
Ok, and now we're wrapping it in another layer. Tricky!
cenedhryn
approved these changes
Apr 25, 2023
aws-sdk-java-automation
added a commit
that referenced
this pull request
May 19, 2025
…c79b30079 Pull request: release <- staging/6ea1a502-2c61-418b-94c7-ceac79b30079
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced with the profile file supplier changes. If the customer was not overriding the profile file via the client override config AND was relying on profile file-based configuration, that configuration would be read with every request. This had a significant performance cost.