Skip to content

Release ruleset-testing-core. #3513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2022
Merged

Release ruleset-testing-core. #3513

merged 2 commits into from
Oct 25, 2022

Conversation

millems
Copy link
Contributor

@millems millems commented Oct 24, 2022

No description provided.

@millems millems requested a review from a team as a code owner October 24, 2022 21:01
@millems
Copy link
Contributor Author

millems commented Oct 24, 2022

@dagnir has mentioned that he has an idea of how to remove it as being a needed dependency. I'll hold off on merging this change until he has a chance to consider doing that.

@dagnir
Copy link
Contributor

dagnir commented Oct 24, 2022

@dagnir has mentioned that he has an idea of how to remove it as being a needed dependency. I'll hold off on merging this change until he has a chance to consider doing that.

Might have been a miscommunication. I was saying that we can also remove mvn clean install -P quick && from the command.

@millems millems force-pushed the millem/release-testing-core branch from e10f52d to 0d93cae Compare October 25, 2022 16:25
@millems
Copy link
Contributor Author

millems commented Oct 25, 2022

@dagnir has mentioned that he has an idea of how to remove it as being a needed dependency. I'll hold off on merging this change until he has a chance to consider doing that.

Might have been a miscommunication. I was saying that we can also remove mvn clean install -P quick && from the command.

Good call. Fixed.

@millems millems enabled auto-merge (squash) October 25, 2022 16:26
@millems millems disabled auto-merge October 25, 2022 17:27
@aws-sdk-java-automation aws-sdk-java-automation merged commit 2385b4f into master Oct 25, 2022
@aws-sdk-java-automation aws-sdk-java-automation deleted the millem/release-testing-core branch October 25, 2022 17:32
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joviegas joviegas joviegas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@millems @dagnir @joviegas @aws-sdk-java-automation