Skip to content

Merge CRT HTTP client changes (request and response refactor) #3507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2022

Conversation

millems
Copy link
Contributor

@millems millems commented Oct 21, 2022

These changes have already been code reviewed.

…body logic.

Added two new publishers to 'utils':
1. StoringSubscriber - A subscriber that stores the events it receives in memory for retrieval.
2. ByteBufferStoringSubscriber - A subscriber that stores byte buffers it recevies in memory for retrieval.
… body logic. (#3490)

* Updated aws-crt-client to use new 'utils' publishers for its response body logic.

Added a new publisher to 'utils': SimplePublisher - A publisher that exposes simple `write`, `complete` and `error` methods, and avoids the caller needing to be concerned about backpressure or following the reactive streams specification.

* Addressed comments.
@millems millems requested a review from a team as a code owner October 21, 2022 17:24
@millems millems enabled auto-merge (squash) October 21, 2022 17:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 60 Code Smells

89.1% 89.1% Coverage
0.0% 0.0% Duplication

@millems millems merged commit 5edc44a into master Oct 21, 2022
@millems millems deleted the millem/crt-cleanup-2 branch October 21, 2022 19:28
aws-sdk-java-automation added a commit that referenced this pull request Dec 4, 2024
…1c780a5ee

Pull request: release <- staging/d90a2039-a3c5-4840-b911-bf51c780a5ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants