Clarify what makes URL browser incompatible #3019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
reviewed
Feb 9, 2022
| * S3Presigner presigner = S3Presigner.builder() | ||
| * .serviceConfiguration(S3Configuration.builder() | ||
| * .checksumValidationEnabled(false) | ||
| * .accelerateModeEnabled(true) |
There was a problem hiding this comment.
Can we remove accelerateModeEnabled? It seems we are suggesting it needs to be enabled to be browser compatible
There was a problem hiding this comment.
I wanted to show a "real world" use case when a customer might want to specify a custom S3Configuration in the first place, but that's a good point. I removed it and clarified the S3Configuration use case in the docs.
dagnir
force-pushed
the
s3-presigner-url-checksum-browser
branch
from
be57c10 to
1b4d1c6
Compare
dagnir
force-pushed
the
s3-presigner-url-checksum-browser
branch
from
1b4d1c6 to
4d2a9c2
Compare
zoewangg
approved these changes
Feb 9, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Clarify somewhat confusing behavior.
Modifications
Javadoc update to clarify that checksum validation makes URL browser incompatible.
Testing
N/A javadoc update.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License