[JUnit 5] Migrate tests which can be easily converted #2878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JUnit 4 -> 5 migrations are often done in a 3-step process: 1. Update dependencies to JUnit 5, including the vintage module, causing all tests to leverage the new JUnit 5 Platform 2. Incrementally migrate JUnit 4 tests to JUnit 5 tests 3. Once no JUnit 4 usage remains, remove the dependency on the vintage module This PR begins step 2 by migrating tests which can be easily converted. IntelliJ provides a convenient way to migrate tests, but unfortunately there is no support for automatically migrating JUnit 4 tests which leverage any of the following: 1. The `expected` parameter in test annotations 2. The `timeout` parameter in test annotations 3. The class-level ``@RunWith` annotation (e.g., `@RunWith(Parameterized.class)` and `@RunWith(MockitoJUnitRunner.class)`) Therefore, this PR leverages the migrate functionality but defers the above scenarios as follows: ``` grep -r -e "@test(" -e "@RunWith(" . | cut -d ':' -f1 | xargs -I {} git restore {} ```
cenedhryn
approved these changes
Dec 1, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
aws-sdk-java-automation
pushed a commit
that referenced
this pull request
Dec 2, 2021
…" because it broke integration tests. This reverts commit 4289e9a98c8db6b25643c40c9e77fdae6af1d5td5.
aws-sdk-java-automation
pushed a commit
that referenced
this pull request
Dec 2, 2021
Revert "[JUnit 5] Migrate tests which can be easily converted (#2878)…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JUnit 4 -> 5 migrations are often done in a 3-step process:
This PR begins step 2 by migrating tests which can be easily converted.
IntelliJ provides a convenient way to migrate tests:
But unfortunately there is no support for automatically migrating JUnit 4 tests which leverage any of the following:
expectedparameter in test annotationstimeoutparameter in test annotations@RunWithannotation (e.g.,@RunWith(Parameterized.class)and@RunWith(MockitoJUnitRunner.class))Therefore, this PR leverages the migrate functionality but defers the above scenarios as follows:
All changes in this PR are fully automated with the migrate functionality, except for the changes to the top-level pom.xml to add
org.junit.*to bothignoredUsedUndeclaredDependencyandignoredUnusedDeclaredDependency.Additionally, there were a few cases of the migrate functionality migrating a superclass but not being able to migrate a subclass (due to the above limitations). The superclass was restored in this case.
License