Handle exceptions thrown by the consumer passed to SdkPublisher.subscribe or filter. #2877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribe or filter. Previously, the future returned by `subscribe` or `filter` would never be completed in this scenario. Now, the result future is completed exceptionally with the exception raised by the consumer.
millems
force-pushed
the
millem/paginator-hang
branch
from
f1bc9c4 to
2ce1a6e
Compare
joviegas
reviewed
Dec 1, 2021
| } | ||
| } catch (RuntimeException e) { | ||
| // Handle the predicate throwing an exception | ||
| subscription.cancel(); |
There was a problem hiding this comment.
Query just for my curiosity : Earlier these exceptions were thrown higher in stack and now we are catching it , do we need to worry about any backward compatibility issue were Users have expecting this exceptions to be caught directly.
There was a problem hiding this comment.
It's against "the rules" to throw out of an onNext (except for null parameters), so we're out of compliance already here. It's possible someone is relying on the old behavior: https://xkcd.com/1172/
joviegas
approved these changes
Dec 1, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the future returned by
subscribeorfilterwould never be completed in this scenario. Now, the result future is completed exceptionally with the exception raised by the consumer.